[feat] 카카오 로그인 및 로그아웃 구현 #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ziiyouth
approved these changes
Jan 10, 2024
There was a problem hiding this comment.
고생했어요!! 로그아웃 할 때는 어차피 토큰을 가지고 있는 상태니까 whiteList에 추가하지 않고 @userid Long userId 를 이용해 받은 memberId 를 가지고 레디스에서 정보 삭제하는 방식으로 가야 할 것 같아요~! 이 부분 수정해보면 조을 거 같습니다 ㅎ,ㅎ
추가로 토큰 재발급은 만료된 엑세스 토큰과 리프레시 토큰을 모두 Request로 받은 뒤에 만료된 엑세스 토큰에서 서비스 자체 UserId를 뽑아서 레디스에 저장된 정보 삭제하면 됩니다 !!
| @@ -9,7 +9,7 @@ | |||
| @Getter | |||
| @NoArgsConstructor(access = AccessLevel.PROTECTED) | |||
| @AllArgsConstructor(access = AccessLevel.PRIVATE) | |||
| @Builder(access = AccessLevel.PRIVATE) | |||
| @Builder(access = AccessLevel.PUBLIC) //수정해야함 | |||
There was a problem hiding this comment.
아래 빌더 달아줬으니까 여기서는 @AllArgsConstructor랑 빌더랑 둘 다 없애도 될 거 같아용용~!
There was a problem hiding this comment.
굿굿 확실히 빼는 게 나을 거 같아요! 멤버 서비스에서는 마이페이지 관련 API업무를 수행하면 좋을 거 같습니다 ㅎㅎ
ziiyouth
reviewed
Jan 10, 2024
There was a problem hiding this comment.
이 친구들 있는 폴더가 response가 아니고 reponse로 되어 있는 거 같은데 확인 부탁해용!!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue 🍫
Summary 🍪
Before i request PR review 🍰